Re: [PATCH] t5318: use 'test_cmp_bin' to compare commit-graph files

2018-08-13 Thread SZEDER Gábor
On Mon, Aug 13, 2018 at 1:24 PM Derrick Stolee wrote: > > On 8/12/2018 4:18 PM, SZEDER Gábor wrote: > > The commit-graph files are binary files, so they should not be > > compared with 'test_cmp', because that might cause issues on Windows, > > where 'test_cmp' is a shell function to deal with ran

Re: [PATCH] t5318: use 'test_cmp_bin' to compare commit-graph files

2018-08-13 Thread Derrick Stolee
On 8/12/2018 4:18 PM, SZEDER Gábor wrote: The commit-graph files are binary files, so they should not be compared with 'test_cmp', because that might cause issues on Windows, where 'test_cmp' is a shell function to deal with random LF-CRLF conversions. Use 'test_cmp_bin' instead. Signed-off-by:

[PATCH] t5318: use 'test_cmp_bin' to compare commit-graph files

2018-08-12 Thread SZEDER Gábor
The commit-graph files are binary files, so they should not be compared with 'test_cmp', because that might cause issues on Windows, where 'test_cmp' is a shell function to deal with random LF-CRLF conversions. Use 'test_cmp_bin' instead. Signed-off-by: SZEDER Gábor --- t/t5318-commit-graph.sh