Re: [PATCH] t1500-rev-parse: rewrite each test to run in isolation

2016-04-16 Thread SZEDER Gábor
Quoting Junio C Hamano : Applying this patch on top of sg/completion-updates topic makes the tests much more readable. Given that sg/completion-updates topic is planned to be rerolled ($gmane/287839), I think it would be better to do this as a preparatory clean-up patch before it makes the tes

Re: [PATCH] t1500-rev-parse: rewrite each test to run in isolation

2016-04-13 Thread Jeff King
On Wed, Apr 13, 2016 at 12:54:16AM -0400, Eric Sunshine wrote: > > -# label is-bare is-inside-git is-inside-work prefix git-dir > > absolute-git-dir > > +test_expect_success '.git/: is-inside-git-dir' ' > > + (cd .git && test true = "$(git rev-parse --is-inside-git-dir)") > > Simpler: > >

Re: [PATCH] t1500-rev-parse: rewrite each test to run in isolation

2016-04-13 Thread Mike Rappazzo
On Wed, Apr 13, 2016 at 12:54 AM, Eric Sunshine wrote: > On Sat, Apr 9, 2016 at 7:19 AM, Michael Rappazzo wrote: >> t1500-rev-parse has many tests which change directories and leak >> environment variables. This makes it difficult to add new tests without >> minding the environment variables and

Re: [PATCH] t1500-rev-parse: rewrite each test to run in isolation

2016-04-12 Thread Eric Sunshine
On Sat, Apr 9, 2016 at 7:19 AM, Michael Rappazzo wrote: > t1500-rev-parse has many tests which change directories and leak > environment variables. This makes it difficult to add new tests without > minding the environment variables and current directory. > > Each test is now setup, executed, and

Re: [PATCH] t1500-rev-parse: rewrite each test to run in isolation

2016-04-12 Thread Junio C Hamano
Michael Rappazzo writes: > t1500-rev-parse has many tests which change directories and leak > environment variables. This makes it difficult to add new tests without > minding the environment variables and current directory. > > Each test is now setup, executed, and cleaned up without leaving an

[PATCH] t1500-rev-parse: rewrite each test to run in isolation

2016-04-09 Thread Michael Rappazzo
t1500-rev-parse has many tests which change directories and leak environment variables. This makes it difficult to add new tests without minding the environment variables and current directory. Each test is now setup, executed, and cleaned up without leaving anything behind. Tests which have tex