Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-14 Thread Junio C Hamano
Jeff King writes: > On Tue, Jan 13, 2015 at 03:40:10PM -0800, Junio C Hamano wrote: > >> >> - test-genrandom seed2 250 >huge && >> >> + printf "\0%250s" Y >huge && >> [...] >> Are we depending on the binary-ness of these test files by the way? >> The leading NUL \0 looked a bit strange to

Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-14 Thread Jeff King
On Tue, Jan 13, 2015 at 03:40:10PM -0800, Junio C Hamano wrote: > >> - test-genrandom seed2 250 >huge && > >> + printf "\0%250s" Y >huge && > [...] > Are we depending on the binary-ness of these test files by the way? > The leading NUL \0 looked a bit strange to me. I don't think so. We

Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-13 Thread Junio C Hamano
Jeff King writes: > On Tue, Jan 13, 2015 at 11:33:08PM +0100, Johannes Sixt wrote: > >> BTW, is it the incompressibility where the time is lost or lack of >> sparseness of the files? How does the timing change with this patch on >> top? > > Oh, good call. It's the incompressibility. Which makes p

Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-13 Thread Jeff King
On Tue, Jan 13, 2015 at 11:33:08PM +0100, Johannes Sixt wrote: > BTW, is it the incompressibility where the time is lost or lack of > sparseness of the files? How does the timing change with this patch on > top? Oh, good call. It's the incompressibility. Which makes perfect sense. Once we copy th

Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-13 Thread Johannes Sixt
Am 13.01.2015 um 22:47 schrieb Jeff King: > On Tue, Jan 13, 2015 at 06:36:27PM +0100, Johannes Sixt wrote: > >> For some unknown reason, the dd on my Windows box segfaults every now >> and than, but since recently, it does so much more often than it used >> to, which makes running the test suite b

Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-13 Thread Jeff King
On Tue, Jan 13, 2015 at 06:36:27PM +0100, Johannes Sixt wrote: > For some unknown reason, the dd on my Windows box segfaults every now > and than, but since recently, it does so much more often than it used > to, which makes running the test suite burdensome. > > Get rid of four invocations of dd

Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-13 Thread Johannes Sixt
Am 13.01.2015 um 19:56 schrieb Junio C Hamano: > Johannes Sixt writes: >> The new code does change some properties of the generated files: >> >> - They are a bit smaller. >> - They are not sparse anymore. >> - They do not compress well anymore. >> - The smaller of the four files is now a prefi

Re: [PATCH] t1050-large: replace dd by test-genrandom

2015-01-13 Thread Junio C Hamano
Johannes Sixt writes: > For some unknown reason, the dd on my Windows box segfaults every now > and than, but since recently, it does so much more often than it used > to, which makes running the test suite burdensome. > > Get rid of four invocations of dd and use test-genrandom instead. > > The

[PATCH] t1050-large: replace dd by test-genrandom

2015-01-13 Thread Johannes Sixt
For some unknown reason, the dd on my Windows box segfaults every now and than, but since recently, it does so much more often than it used to, which makes running the test suite burdensome. Get rid of four invocations of dd and use test-genrandom instead. The new code does change some properties