Re: [PATCH] t: use LF variable defined in the test harness

2019-09-05 Thread Junio C Hamano
Jeff King writes: > On Thu, Sep 05, 2019 at 11:17:57AM -0700, Junio C Hamano wrote: > >> Somebody may want to go clean-up the use of various $sq and $SQ >> locally defined by giving a unified $SQ in test-lib.sh, by the way. > > Maybe good #leftoverbits material, since we may have Outreachy > appl

Re: [PATCH] t: use LF variable defined in the test harness

2019-09-05 Thread Taylor Blau
On Thu, Sep 05, 2019 at 11:17:57AM -0700, Junio C Hamano wrote: > Taylor Blau writes: > > > - t/t3005: this script calls the variable '$new_line', but could be > > renamed to LF and then removed in a second patch > > It is worse than that, isn't it? > > If it used $new_line, then it would pr

Re: [PATCH] t: use LF variable defined in the test harness

2019-09-05 Thread Jeff King
On Thu, Sep 05, 2019 at 11:17:57AM -0700, Junio C Hamano wrote: > Somebody may want to go clean-up the use of various $sq and $SQ > locally defined by giving a unified $SQ in test-lib.sh, by the way. Maybe good #leftoverbits material, since we may have Outreachy applications coming up soon. -Pef

Re: [PATCH] t: use LF variable defined in the test harness

2019-09-05 Thread Junio C Hamano
Taylor Blau writes: > - t/t3005: this script calls the variable '$new_line', but could be > renamed to LF and then removed in a second patch It is worse than that, isn't it? If it used $new_line, then it would probably have been a good idea to somehow make a separate patch related to this

Re: [PATCH] t: use LF variable defined in the test harness

2019-09-03 Thread Taylor Blau
Hi Junio, On Tue, Sep 03, 2019 at 02:11:22PM -0700, Junio C Hamano wrote: > A few test scripts assign a single LF to $LF, but that is already > given by test-lib.sh to everybody. I didn't know that 't/test-lib.sh' provided '$LF' (as I'm sure was the case for the respective authors of those tests

[PATCH] t: use LF variable defined in the test harness

2019-09-03 Thread Junio C Hamano
A few test scripts assign a single LF to $LF, but that is already given by test-lib.sh to everybody. Remove the unnecessary reassignment. Signed-off-by: Junio C Hamano --- t/t3404-rebase-interactive.sh | 2 -- t/t4013-diff-various.sh | 3 --- t/t5515-fetch-merge-logic.sh | 3 --- 3 files