Re: [PATCH] t/perf: export variable used in other blocks

2017-03-03 Thread Jeff King
On Fri, Mar 03, 2017 at 10:51:57AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Thanks, this is obviously the right thing to do, and the mistake is mine > > from ea97002fc (t/perf: time rev-list with UNINTERESTING commits, > > 2014-01-20). This is not the first time I've been confused

Re: [PATCH] t/perf: export variable used in other blocks

2017-03-03 Thread Junio C Hamano
Jeff King writes: > Thanks, this is obviously the right thing to do, and the mistake is mine > from ea97002fc (t/perf: time rev-list with UNINTERESTING commits, > 2014-01-20). This is not the first time I've been confused by missing > variables in t/perf scripts, since it behaves differently than

[PATCH] t/perf: export variable used in other blocks

2017-03-02 Thread Jonathan Tan
In p0001, a variable was created in a test_expect_success block to be used in later test_perf blocks, but was not exported. This caused the variable to not appear in those blocks (this can be verified by writing 'test -n "$commit"' in those blocks), resulting in a slightly different invocation than

Re: [PATCH] t/perf: export variable used in other blocks

2017-03-02 Thread Jeff King
On Thu, Mar 02, 2017 at 11:50:41AM -0800, Jonathan Tan wrote: > In p0001, a variable was created in a test_expect_success block to be > used in later test_perf blocks, but was not exported. This caused the > variable to not appear in those blocks (this can be verified by writing > 'test -n "$commi