Re: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1

2014-12-03 Thread Junio C Hamano
Michael J Gruber writes: > Orthogonal to that is the pinentry issue: I haven't checked whether > gpg2.1 asking for passphrases on passphrase-less secure keys is to be > fixed on the gpg side. If yes, I would just wait for that since gpg2.1 > is not common yet. > > If not, we should provide (in gp

Re: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1

2014-12-03 Thread Junio C Hamano
Jeff King writes: > On Tue, Dec 02, 2014 at 03:57:50PM -0800, Junio C Hamano wrote: > >> Wait. After doing this, >> >> $ mkdir -p src/a && >src/b 2>src/a/c && chmod a-w src/b src/a/c >> $ cp -R src dst >> $ ls -lR dst >> >> dst/b and dst/a/c are 0440 (with umask 0027, which makes s

Re: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1

2014-12-03 Thread Michael J Gruber
Jeff King schrieb am 02.12.2014 um 22:07: > On Tue, Dec 02, 2014 at 02:40:27PM +0100, Michael J Gruber wrote: > >> Before gnupg 2.1 (aka "modern branch"), gpghome would contain only files >> which allowed t/lib-gpg.sh to set permissions explicitely, and we did >> that since >> 28a1b07 (t/lib-gpg:

Re: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1

2014-12-02 Thread Jeff King
On Tue, Dec 02, 2014 at 03:57:50PM -0800, Junio C Hamano wrote: > Wait. After doing this, > > $ mkdir -p src/a && >src/b 2>src/a/c && chmod a-w src/b src/a/c > $ cp -R src dst > $ ls -lR dst > > dst/b and dst/a/c are 0440 (with umask 0027, which makes src/b and > src/a/c also 0440,

Re: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1

2014-12-02 Thread Junio C Hamano
Jeff King writes: > Taking a step back, though, I am not sure I understand the reasoning > behind the original e7f224f. The rationale in the commit message is that > we want to make sure that the files are writable. But why would they not > be? They are created by "cp -R",... Wait. After doing

Re: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1

2014-12-02 Thread Jeff King
On Tue, Dec 02, 2014 at 02:40:27PM +0100, Michael J Gruber wrote: > Before gnupg 2.1 (aka "modern branch"), gpghome would contain only files > which allowed t/lib-gpg.sh to set permissions explicitely, and we did > that since > 28a1b07 (t/lib-gpg: adjust permissions for gnupg 2.1, 2014-12-02) > in

[PATCH] t/lib-gpg: adjust permissions for gnupg 2.1

2014-12-02 Thread Michael J Gruber
Before gnupg 2.1 (aka "modern branch"), gpghome would contain only files which allowed t/lib-gpg.sh to set permissions explicitely, and we did that since 28a1b07 (t/lib-gpg: adjust permissions for gnupg 2.1, 2014-12-02) in order to adjust wrong permissions from a checkout on ro file systems. gnupg