Re: [PATCH] submodule.sh update --remote: default to oid instead of master

2018-09-06 Thread Jonathan Nieder
Stefan Beller wrote: > On Wed, Sep 5, 2018 at 4:10 PM Jonathan Nieder wrote: >> Broader comment: do you think people will be surprised by this new >> behavior? Is there anything special we'd need to do to call it out >> (e.g., print a warning or put something in release notes)? > > I guess. Not

Re: [PATCH] submodule.sh update --remote: default to oid instead of master

2018-09-06 Thread Stefan Beller
On Wed, Sep 5, 2018 at 4:10 PM Jonathan Nieder wrote: > > Stefan Beller wrote: > > > Subject: submodule.sh update --remote: default to oid instead of master > > Yay! > > Nit: it wasn't clear to me at first what default this subject line was > referring to. Perhaps: > > submodule update --

Re: [PATCH] submodule.sh update --remote: default to oid instead of master

2018-09-05 Thread Jonathan Nieder
Stefan Beller wrote: > Subject: submodule.sh update --remote: default to oid instead of master Yay! Nit: it wasn't clear to me at first what default this subject line was referring to. Perhaps: submodule update --remote: skip GITLINK update when no branch is set [...] > --- a/Document

[PATCH] submodule.sh update --remote: default to oid instead of master

2018-09-05 Thread Stefan Beller
gitmodules(5) sayeth: submodule..branch A remote branch name for tracking updates in the upstream submodule. If the option is not specified, it defaults to master. This doesn't allow having a "pinned" submodule that should not be updated from upstream. We should change this to ha