Re: [PATCH] submodule operations: tighten pathspec errors

2016-06-06 Thread Stefan Beller
On Wed, Jun 1, 2016 at 2:14 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Thu, May 26, 2016 at 1:00 PM, Junio C Hamano wrote: >> @@ -36,10 +37,9 @@ static int module_list_compute(int argc, const char **argv, for (i = 0; i < active_nr; i++) {

Re: [PATCH] submodule operations: tighten pathspec errors

2016-06-01 Thread Junio C Hamano
Junio C Hamano writes: >> Ok I'll fix the variable names; I think for consistency with e.g. >> ls-files --error-unmatch >> we would want to be loose by default and strict on that option. > > I do not think the "typo-prevention" safety measure should suddenly > be turned into opt-in; I'd suggest "

Re: [PATCH] submodule operations: tighten pathspec errors

2016-06-01 Thread Junio C Hamano
Stefan Beller writes: > On Thu, May 26, 2016 at 1:00 PM, Junio C Hamano wrote: > >>> @@ -36,10 +37,9 @@ static int module_list_compute(int argc, const char >>> **argv, >>> >>> for (i = 0; i < active_nr; i++) { >>> const struct cache_entry *ce = active_cache[i]; >>> - >>> -

Re: [PATCH] submodule operations: tighten pathspec errors

2016-06-01 Thread Stefan Beller
On Thu, May 26, 2016 at 1:00 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> It's a first initial version with no tests (and probably conflicting with >> some topics in flight), but I was curious how involved this issue actually >> is, >> so I took a stab at implementing it. > > I take it

Re: [PATCH] submodule operations: tighten pathspec errors

2016-05-26 Thread Junio C Hamano
Stefan Beller writes: > It's a first initial version with no tests (and probably conflicting with > some topics in flight), but I was curious how involved this issue actually is, > so I took a stab at implementing it. I take it to mean "This is s/PATCH/RFC/". > +--error-unmatch:: > + If the

[PATCH] submodule operations: tighten pathspec errors

2016-05-20 Thread Stefan Beller
when the pathspec did not match any path, error out. Add the `--error-unmatch` switch to use the old behavior. Signed-off-by: Stefan Beller --- This was taken from the Left Over Bits: git submodule $cmd $pathspec may want to error out when the $pathspec does not match any submodules. There