Re: [PATCH] submodule--helper: do not call utf8_fprintf() unnecessarily

2017-06-28 Thread Stefan Beller
On Wed, Jun 28, 2017 at 1:58 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Wed, Jun 28, 2017 at 1:38 PM, Junio C Hamano wrote: >>> The helper function utf8_fprintf(fp, ...) has exactly the same >>> effect to the output stream fp as fprintf(fp, ...) does, and the >>> only difference i

Re: [PATCH] submodule--helper: do not call utf8_fprintf() unnecessarily

2017-06-28 Thread Junio C Hamano
Stefan Beller writes: > On Wed, Jun 28, 2017 at 1:38 PM, Junio C Hamano wrote: >> The helper function utf8_fprintf(fp, ...) has exactly the same >> effect to the output stream fp as fprintf(fp, ...) does, and the >> only difference is that its return value counts in display columns >> consumed (

Re: [PATCH] submodule--helper: do not call utf8_fprintf() unnecessarily

2017-06-28 Thread Stefan Beller
On Wed, Jun 28, 2017 at 1:38 PM, Junio C Hamano wrote: > The helper function utf8_fprintf(fp, ...) has exactly the same > effect to the output stream fp as fprintf(fp, ...) does, and the > only difference is that its return value counts in display columns > consumed (assuming that the payload is e

[PATCH] submodule--helper: do not call utf8_fprintf() unnecessarily

2017-06-28 Thread Junio C Hamano
The helper function utf8_fprintf(fp, ...) has exactly the same effect to the output stream fp as fprintf(fp, ...) does, and the only difference is that its return value counts in display columns consumed (assuming that the payload is encoded in UTF-8), as opposed to number of bytes. There is no re