Re: [PATCH] submodule: test moving recursive submodule

2016-06-28 Thread Stefan Beller
On Mon, Jun 27, 2016 at 11:28 PM, Bart Bogaerts wrote: > I dit some more testing. > > It is important for the bug to occur that all submodules are initialised. > So my suggestion is not yet complete, you need to add the line Oh right. I was completely oblivious to that. > > git submodule update

Re: [PATCH] submodule: test moving recursive submodule

2016-06-27 Thread Bart Bogaerts
I dit some more testing. It is important for the bug to occur that all submodules are initialised. So my suggestion is not yet complete, you need to add the line git submodule update --recursive --init Below is a complete script that show the bug occurring: mkdir repo1 && mkdir repo2 && (

Re: [PATCH] submodule: test moving recursive submodule

2016-06-27 Thread Bart Bogaerts
The only thing I still see that might cause the bug is that there is no git submodule update --recursive present in your test cases . This command creates the .git file in the nested subsubmodule It is that .git file that is not correctly updated in the move. So after the line + git submod

[PATCH] submodule: test moving recursive submodule

2016-06-27 Thread Stefan Beller
Signed-off-by: Stefan Beller --- This tries to reproduce the error as pointed out in http://stackoverflow.com/questions/32782382/git-moving-submodules-recursively-nested-submodules but the tests pass. This still seems to be missing a detail. Bart any idea how this setup may be different than what