Re: [PATCH] submodule: do no re-read name in shell script

2016-07-20 Thread Stefan Beller
On Wed, Jul 20, 2016 at 6:00 PM, Jonathan Nieder wrote: >> - needs_cloning, ce->name); >> + needs_cloning, sub->name, sub->path); > > Are there any restrictions on what characters a submodule name can > contain? Does this need e.g. to be quoted with sq_quo

Re: [PATCH] submodule: do no re-read name in shell script

2016-07-20 Thread Jonathan Nieder
Stefan Beller wrote: > Instead of making another call to a submodule helper (name), just > propagate the value when we know it (in the update-clone helper) already. > > Signed-off-by: Stefan Beller > --- > builtin/submodule--helper.c | 4 ++-- > git-submodule.sh| 3 +-- > 2 files cha

[PATCH] submodule: do no re-read name in shell script

2016-07-20 Thread Stefan Beller
Instead of making another call to a submodule helper (name), just propagate the value when we know it (in the update-clone helper) already. Signed-off-by: Stefan Beller --- builtin/submodule--helper.c | 4 ++-- git-submodule.sh| 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)