Re: [PATCH] submodule: correct error message for missing commits.

2017-09-26 Thread Junio C Hamano
Stefan Beller writes: > When a submodule diff should be displayed we currently just add the > submodule objects to the main object store and then e.g. walk the > revision graph and create a summary for that submodule. > > It is possible that we are missing the submodule either completely or > par

Re: [PATCH] submodule: correct error message for missing commits.

2017-09-26 Thread Jacob Keller
On Tue, Sep 26, 2017 at 11:27 AM, Stefan Beller wrote: > When a submodule diff should be displayed we currently just add the > submodule objects to the main object store and then e.g. walk the > revision graph and create a summary for that submodule. > > It is possible that we are missing the subm

[PATCH] submodule: correct error message for missing commits.

2017-09-26 Thread Stefan Beller
When a submodule diff should be displayed we currently just add the submodule objects to the main object store and then e.g. walk the revision graph and create a summary for that submodule. It is possible that we are missing the submodule either completely or partially, which we currently differen

Re: [PATCH] submodule: correct error message for missing commits.

2017-07-26 Thread Junio C Hamano
Stefan Beller writes: > We _do_ show the submodule as demonstrated by the code sample above > if we possess the objects. > ... >> That sounds like a very sensible and user-centric behaviour to me, >> and "not initialized" sounds like the right message to give in such >> a case (as opposed to "com

Re: [PATCH] submodule: correct error message for missing commits.

2017-07-26 Thread Stefan Beller
On Wed, Jul 26, 2017 at 1:30 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> When a submodule diff should be displayed we currently just add the >> submodule objects to the main object store and then e.g. walk the >> revision graph and create a summary for that submodule. >> >> It is possi

Re: [PATCH] submodule: correct error message for missing commits.

2017-07-26 Thread Junio C Hamano
Stefan Beller writes: > When a submodule diff should be displayed we currently just add the > submodule objects to the main object store and then e.g. walk the > revision graph and create a summary for that submodule. > > It is possible that we are missing the submodule either completely or > par

[PATCH] submodule: correct error message for missing commits.

2017-07-26 Thread Stefan Beller
When a submodule diff should be displayed we currently just add the submodule objects to the main object store and then e.g. walk the revision graph and create a summary for that submodule. It is possible that we are missing the submodule either completely or partially, which we currently differen