Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Junio C Hamano
Orgad Shaneh writes: > +--verbose:: > + This option is valid for add and update commands. Display the progress > + of the actual submodule checkout. Hmm, is the "valid for add and update" part we want to keep? I do not think it is a crime if some other subcommand accepted --verbose opti

[PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Orgad Shaneh
Add the verbose flag to add and update which displays the progress of the actual submodule checkout when given. This is useful for checkouts that take a long time, as the user can then see the progress. Signed-off-by: Orgad Shaneh --- Documentation/git-submodule.txt | 7 +-- git-submodule.s

Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Orgad Shaneh
On Wed, Mar 12, 2014 at 6:15 PM, Jens Lehmann wrote: > > Am 12.03.2014 14:42, schrieb Orgad Shaneh: > > From: Orgad Shaneh > > You don't need the line above when you are the sender ;-) > > > Executes checkout without -q > > That's a bit terse. What about: > > "Add the verbose flag to add and upda

Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Jens Lehmann
Am 12.03.2014 14:42, schrieb Orgad Shaneh: > From: Orgad Shaneh You don't need the line above when you are the sender ;-) > Executes checkout without -q That's a bit terse. What about: "Add the verbose flag to add and update which displays the progress of the actual submodule checkout when gi

[PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Orgad Shaneh
From: Orgad Shaneh Executes checkout without -q Signed-off-by: Orgad Shaneh --- Documentation/git-submodule.txt | 7 +-- git-submodule.sh| 24 +++- t/t7406-submodule-update.sh | 9 + 3 files changed, 33 insertions(+), 7 deletions(-) diff -

Re: [PATCH] submodule: add verbose mode for add/update

2014-03-12 Thread Eric Sunshine
On Mar 12, 2014, at 2:38 AM, Orgad Shaneh wrote: > Executes checkout without -q > — Missing sign-off. See Documentation/SubmittingPatches. Your patch is badly whitespace-damaged, as if it was pasted into your email client. “git send-email” can avoid this problem. As I’m not a submodule user, I

[PATCH] submodule: add verbose mode for add/update

2014-03-11 Thread Orgad Shaneh
Executes checkout without -q --- git-submodule.sh | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index a33f68d..5c4e057 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -5,11 +5,11 @@ # Copyright (c) 2007 La

Fwd: [PATCH] submodule: add verbose mode for add/update

2013-04-10 Thread Orgad Shaneh
On Wed, Apr 10, 2013 at 11:00 PM, Jens Lehmann wrote: > > Am 10.04.2013 20:24, schrieb Orgad Shaneh: > > Executes checkout without -q > > Nice, looks like you picked the proposal I made last September: > http://permalink.gmane.org/gmane.comp.version-control.git/204747 Took me a while, but I fin

[PATCH] submodule: add verbose mode for add/update

2013-04-10 Thread Orgad Shaneh
When 'git submodule add/update' is run there is no output during checkout. This can take a significant amount of time and it would be nice if user could enable some feedback to see what's going on. Add the -v/--verbose option to both add and update which suppresses the -q normally given to checkou

Re: [PATCH] submodule: add verbose mode for add/update

2013-04-10 Thread Jens Lehmann
Am 10.04.2013 20:24, schrieb Orgad Shaneh: > Executes checkout without -q Nice, looks like you picked the proposal I made last September: http://permalink.gmane.org/gmane.comp.version-control.git/204747 The change is looking good, but you still need to document the new option in Documentation/g

[PATCH] submodule: add verbose mode for add/update

2013-04-10 Thread Orgad Shaneh
Executes checkout without -q --- git-submodule.sh | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index 79bfaac..f7964ad 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -5,11 +5,11 @@ # Copyright (c) 2007