Re: [PATCH] string-list.h: Add a value to string_list initializer lists

2014-06-02 Thread Junio C Hamano
Tanay Abhra writes: > Add a NULL value in the end of STRING_LIST_INIT_NODUP and > STRING_LIST_DUP to initialize `compare_strings_fn`. Hmph. That is "what change is proposed", which we can read from the patch text itself below. We would want to see "why is this change a good thing" to justify i

Re: [PATCH] string-list.h: Add a value to string_list initializer lists

2014-06-02 Thread Matthieu Moy
Tanay Abhra writes: > Add a NULL value in the end of STRING_LIST_INIT_NODUP and > STRING_LIST_DUP to initialize `compare_strings_fn`. > > Signed-off-by: Tanay Abhra > --- > When I used a malloced string_list to play around with string-list API and > used the default init_list, it caused a seg fa

[PATCH] string-list.h: Add a value to string_list initializer lists

2014-06-02 Thread Tanay Abhra
Add a NULL value in the end of STRING_LIST_INIT_NODUP and STRING_LIST_DUP to initialize `compare_strings_fn`. Signed-off-by: Tanay Abhra --- When I used a malloced string_list to play around with string-list API and used the default init_list, it caused a seg fault. After an hour of debugging I s