Re: [PATCH] stash: fix show referencing stash index

2019-06-24 Thread Mike Hommey
On Sat, Jun 15, 2019 at 12:26:18PM +0100, Thomas Gummerer wrote: > On 06/14, Mike Hommey wrote: > > Hi, > > > > `git stash ` where n is a number used to work until 2.21.*. > > It doesn't work in 2.22.0. > > > > Bisection points to: > > > > dc7bd382b1063303f4f45d243bff371899285acb is the first b

Re: [PATCH] stash: fix show referencing stash index

2019-06-16 Thread Thomas Gummerer
On 06/15, Andrei Rybak wrote: > On 6/15/19 1:26 PM, Thomas Gummerer wrote: > > diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh > > index ea30d5f6a0..3973cbda0e 100755 > > --- a/t/t3903-stash.sh > > +++ b/t/t3903-stash.sh > > @@ -708,6 +708,24 @@ test_expect_success 'invalid ref of the form "n", n

Re: [PATCH] stash: fix show referencing stash index

2019-06-15 Thread Andrei Rybak
On 6/15/19 1:26 PM, Thomas Gummerer wrote: > diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh > index ea30d5f6a0..3973cbda0e 100755 > --- a/t/t3903-stash.sh > +++ b/t/t3903-stash.sh > @@ -708,6 +708,24 @@ test_expect_success 'invalid ref of the form "n", n >= > N' ' > git stash drop > ' >

[PATCH] stash: fix show referencing stash index

2019-06-15 Thread Thomas Gummerer
ands. If not, could you point me to where else you saw this bug? Below is a patch that should fix it. --- >8 --- Subject: [PATCH] stash: fix show referencing stash index In the conversion of 'stash show' to C in dc7bd382b1 ("stash: convert show to builtin", 2019-02-25), &