Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-29 Thread Namhyung Kim
Hi, On Sat, Aug 29, 2015 at 3:10 AM, Junio C Hamano wrote: > Namhyung Kim writes: > >>> Perhaps a pair of new booleans >>> >>> - stash.showStat (defaults to true but you can turn it off) >>> - stash.showPatch (defaults to false but you can turn it on) >>> >>> or something along that line might

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-28 Thread Junio C Hamano
Namhyung Kim writes: >> Perhaps a pair of new booleans >> >> - stash.showStat (defaults to true but you can turn it off) >> - stash.showPatch (defaults to false but you can turn it on) >> >> or something along that line might be sufficient and more palatable. > > Hmm.. I agree with you, but I

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Hi, On Thu, Aug 27, 2015 at 06:08:39PM -0700, Junio C Hamano wrote: > Namhyung Kim writes: > > > +stash.showFlag:: > > + The default option to pass to `git stash show` when no option is > > + given. The default is '--stat'. See description of 'show' command > > + in linkgit:git-stash[1].

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Hi, On Thu, Aug 27, 2015 at 08:16:35PM -0400, Eric Sunshine wrote: > On Thu, Aug 27, 2015 at 11:36 AM, Namhyung Kim wrote: > > On Fri, Aug 28, 2015 at 12:20 AM, SZEDER Gábor wrote: > >> - This hunk runs the the exact same 'git config' command twice. Run it > >>only once, perhaps something

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Junio C Hamano
Namhyung Kim writes: > +stash.showFlag:: > + The default option to pass to `git stash show` when no option is > + given. The default is '--stat'. See description of 'show' command > + in linkgit:git-stash[1]. Doesn't the same discussion in $gmane/275752 apply here? By designing the

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Eric Sunshine
On Thu, Aug 27, 2015 at 11:36 AM, Namhyung Kim wrote: > On Fri, Aug 28, 2015 at 12:20 AM, SZEDER Gábor wrote: >> - This hunk runs the the exact same 'git config' command twice. Run it >>only once, perhaps something like this: >> >> show_flag=$(git config --get stash.showflag || echo --

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Hi, On Fri, Aug 28, 2015 at 12:20 AM, SZEDER Gábor wrote: > Hi, > > I haven't made up my mind about this feature yet, but have a few > comments about its implementation. Thanks for taking your time! > >> diff --git a/git-stash.sh b/git-stash.sh >> index 1d5ba7a..8432435 100755 >> --- a/git-stas

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread SZEDER Gábor
Hi, I haven't made up my mind about this feature yet, but have a few comments about its implementation. > diff --git a/git-stash.sh b/git-stash.sh > index 1d5ba7a..8432435 100755 > --- a/git-stash.sh > +++ b/git-stash.sh > @@ -33,6 +33,12 @@ else > reset_color= > fi > > +if git config

[PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Some users might want to see diff (patch) output always rather than diffstat when [s]he runs 'git stash show'. Although this can be done with adding -p option, it'd be better to provide a config option to control this behavior IMHO. Signed-off-by: Namhyung Kim --- Documentation/config.txt|