Re: [PATCH] squash! completion: fill COMPREPLY directly when completing refs

2017-02-13 Thread Junio C Hamano
SZEDER Gábor writes: > On Fri, Feb 10, 2017 at 10:44 PM, Junio C Hamano wrote: > >> Should I expect a reroll to come, or is this the only fix-up to the >> series that begins at <20170203025405.8242-1-szeder@gmail.com>? >> >> No hurries. > > Yes, definitely. > > I found a minor bug in the mid

Re: [PATCH] squash! completion: fill COMPREPLY directly when completing refs

2017-02-13 Thread SZEDER Gábor
On Fri, Feb 10, 2017 at 10:44 PM, Junio C Hamano wrote: > Should I expect a reroll to come, or is this the only fix-up to the > series that begins at <20170203025405.8242-1-szeder@gmail.com>? > > No hurries. Yes, definitely. I found a minor bug in the middle of the series, and haven't quite

Re: [PATCH] squash! completion: fill COMPREPLY directly when completing refs

2017-02-10 Thread Junio C Hamano
SZEDER Gábor writes: > Care should be taken, though, because that prefix might contain > 'for-each-ref' format specifiers as part of the left hand side of a > '..' range or '...' symmetric difference notation or fetch/push/etc. > refspec, e.g. 'git log "evil-%(refname)..br'. Doubling every '%' >

[PATCH] squash! completion: fill COMPREPLY directly when completing refs

2017-02-06 Thread SZEDER Gábor
Care should be taken, though, because that prefix might contain 'for-each-ref' format specifiers as part of the left hand side of a '..' range or '...' symmetric difference notation or fetch/push/etc. refspec, e.g. 'git log "evil-%(refname)..br'. Doubling every '%' in the prefix will prevent 'git