Re: [PATCH] sha1_name: reorganize get_sha1_basic()

2013-05-02 Thread Felipe Contreras
On Thu, May 2, 2013 at 5:19 AM, Duy Nguyen wrote: > On Thu, May 2, 2013 at 7:49 AM, Felipe Contreras > wrote: >> Through the years the functionality to handle @{-N} and @{u} has moved >> around the code, and as a result, code that once made sense, doesn't any >> more. >> >> There is no need to ca

Re: [PATCH] sha1_name: reorganize get_sha1_basic()

2013-05-02 Thread Duy Nguyen
On Thu, May 2, 2013 at 7:49 AM, Felipe Contreras wrote: > Through the years the functionality to handle @{-N} and @{u} has moved > around the code, and as a result, code that once made sense, doesn't any > more. > > There is no need to call this function recursively with the branch of > @{-N} subs

Re: [PATCH] sha1_name: reorganize get_sha1_basic()

2013-05-02 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > @@ -447,6 +449,9 @@ static int get_sha1_basic(const char *str, int len, > unsigned char *sha1) > if (len && str[len-1] == '}') { > for (at = len-2; at >= 0; at--) { > if (str[at] == '@' && str[at+1] == '{') { > +

Re: [PATCH] sha1_name: reorganize get_sha1_basic()

2013-05-01 Thread Felipe Contreras
On Wed, May 1, 2013 at 7:49 PM, Felipe Contreras wrote: > Through the years the functionality to handle @{-N} and @{u} has moved > around the code, and as a result, code that once made sense, doesn't any > more. > > There is no need to call this function recursively with the branch of > @{-N} subs

Re: [PATCH] sha1_name: reorganize get_sha1_basic()

2013-05-01 Thread Felipe Contreras
On Wed, May 1, 2013 at 7:49 PM, Felipe Contreras wrote: > Through the years the functionality to handle @{-N} and @{u} has moved > around the code, and as a result, code that once made sense, doesn't any > more. > > There is no need to call this function recursively with the branch of > @{-N} subs

[PATCH] sha1_name: reorganize get_sha1_basic()

2013-05-01 Thread Felipe Contreras
Through the years the functionality to handle @{-N} and @{u} has moved around the code, and as a result, code that once made sense, doesn't any more. There is no need to call this function recursively with the branch of @{-N} substituted because dwim_{ref,log} already replaces it. However, there'