Re: [PATCH] sha1_file.c: rename move_temp_to_file() to finalize_temp_file()

Jeff King writes: > On Fri, Aug 07, 2015 at 05:24:29PM -0700, Junio C Hamano wrote: > >> Since 5a688fe4 ("core.sharedrepository = 0mode" should set, not >> loosen, 2009-03-25), we kept reminding ourselves: >> >> NEEDSWORK: this should be renamed to finalize_temp_file() as >> "moving" is

Re: [PATCH] sha1_file.c: rename move_temp_to_file() to finalize_temp_file()

On Fri, Aug 07, 2015 at 05:24:29PM -0700, Junio C Hamano wrote: > Since 5a688fe4 ("core.sharedrepository = 0mode" should set, not > loosen, 2009-03-25), we kept reminding ourselves: > > NEEDSWORK: this should be renamed to finalize_temp_file() as > "moving" is only a part of what it does,

[PATCH] sha1_file.c: rename move_temp_to_file() to finalize_temp_file()

Since 5a688fe4 ("core.sharedrepository = 0mode" should set, not loosen, 2009-03-25), we kept reminding ourselves: NEEDSWORK: this should be renamed to finalize_temp_file() as "moving" is only a part of what it does, when no patch between master to pu changes the call sites of this func