Re: [PATCH] sha1_file: make read_info_alternates static

2017-08-15 Thread Jeff King
On Tue, Aug 15, 2017 at 01:13:19PM -0700, Stefan Beller wrote: > read_info_alternates is not used from outside, so let's make it static. > > We have to declare the function before link_alt_odb_entry instead of > moving the code around, link_alt_odb_entry calls read_info_alternates, > which in tur

Re: [PATCH] sha1_file: make read_info_alternates static

2017-08-15 Thread Brandon Williams
On 08/15, Stefan Beller wrote: > read_info_alternates is not used from outside, so let's make it static. > > We have to declare the function before link_alt_odb_entry instead of > moving the code around, link_alt_odb_entry calls read_info_alternates, > which in turn calls link_alt_odb_entry. > >

[PATCH] sha1_file: make read_info_alternates static

2017-08-15 Thread Stefan Beller
read_info_alternates is not used from outside, so let's make it static. We have to declare the function before link_alt_odb_entry instead of moving the code around, link_alt_odb_entry calls read_info_alternates, which in turn calls link_alt_odb_entry. Signed-off-by: Stefan Beller --- This hel