Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

2014-02-22 Thread Thomas Rast
Junio C Hamano writes: > Jeff King writes: > >> On Fri, Feb 21, 2014 at 06:47:47AM +0700, Nguyễn Thái Ngọc Duy wrote: >> >>> This delta_stack array can grow to any length depending on the actual >>> delta chain, but we forget to free it. Normally it does not matter >>> because we use small_delta

Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

2014-02-22 Thread Jeff King
On Fri, Feb 21, 2014 at 10:09:33AM -0800, Junio C Hamano wrote: > >> This delta_stack array can grow to any length depending on the actual > >> delta chain, but we forget to free it. Normally it does not matter > >> because we use small_delta_stack[] from stack and small_delta_stack > >> can hold

Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

2014-02-21 Thread Junio C Hamano
Jeff King writes: > On Fri, Feb 21, 2014 at 06:47:47AM +0700, Nguyễn Thái Ngọc Duy wrote: > >> This delta_stack array can grow to any length depending on the actual >> delta chain, but we forget to free it. Normally it does not matter >> because we use small_delta_stack[] from stack and small_del

Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

2014-02-20 Thread Jeff King
On Fri, Feb 21, 2014 at 06:47:47AM +0700, Nguyễn Thái Ngọc Duy wrote: > This delta_stack array can grow to any length depending on the actual > delta chain, but we forget to free it. Normally it does not matter > because we use small_delta_stack[] from stack and small_delta_stack > can hold 64-del

[PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

2014-02-20 Thread Nguyễn Thái Ngọc Duy
This delta_stack array can grow to any length depending on the actual delta chain, but we forget to free it. Normally it does not matter because we use small_delta_stack[] from stack and small_delta_stack can hold 64-delta chains, more than standard --depth=50 in pack-objects. Signed-off-by: Nguyễ