Re: [PATCH] sequencer.c: unify error messages

2017-10-15 Thread Ralf Thielow
2017-10-13 23:12 GMT+02:00 René Scharfe : > Am 13.10.2017 um 19:51 schrieb Ralf Thielow: >> When ftruncate() in rearrange_squash() fails, we write >> that we couldn't finish the operation on the todo file. >> It is more accurate to write that we couldn't truncate >> as we do in other calls of ftrun

Re: [PATCH] sequencer.c: unify error messages

2017-10-15 Thread Johannes Schindelin
Hi Ralf, On Fri, 13 Oct 2017, Ralf Thielow wrote: > When ftruncate() in rearrange_squash() fails, we write > that we couldn't finish the operation on the todo file. > It is more accurate to write that we couldn't truncate > as we do in other calls of ftruncate(). > > While at there, remove a ful

Re: [PATCH] sequencer.c: unify error messages

2017-10-13 Thread René Scharfe
Am 13.10.2017 um 19:51 schrieb Ralf Thielow: > When ftruncate() in rearrange_squash() fails, we write > that we couldn't finish the operation on the todo file. > It is more accurate to write that we couldn't truncate > as we do in other calls of ftruncate(). Would it make sense to factor out rewri

[PATCH] sequencer.c: unify error messages

2017-10-13 Thread Ralf Thielow
When ftruncate() in rearrange_squash() fails, we write that we couldn't finish the operation on the todo file. It is more accurate to write that we couldn't truncate as we do in other calls of ftruncate(). While at there, remove a full stop in another error message. Signed-off-by: Ralf Thielow -