"phillip.w...@talktalk.net" writes:
>>Original Message
>>From: johannes.schinde...@gmx.de
>>Date: 22/12/2017 11:50
>>To:
>>Cc: "Junio C Hamano", "Phillip Wood" w...@dunelm.org.uk>, "Kaartic Sivaraam"
>&
Johannes Schindelin writes:
>> I thought the bug could be triggered when commit.gpgsign was true and
>> it was not overriden on the commandline, is it worth adding a test for
>> that?
>
> ... If we want to verify that the
> gpg_sign is correctly allocated before it is free()d, then the test cas
Hi Phillip,
On Fri, 22 Dec 2017, phillip.w...@talktalk.net wrote:
> I thought the bug could be triggered when commit.gpgsign was true and
> it was not overriden on the commandline, is it worth adding a test for
> that?
Everybody working with extensive test suites seems to write/blog these
days
>Original Message
>From: johannes.schinde...@gmx.de
>Date: 22/12/2017 11:50
>To:
>Cc: "Junio C Hamano", "Phillip Wood", "Kaartic Sivaraam"
>Subj: [PATCH] sequencer: assign only free()able strings to gpg_sign
>
>The gpg_sig
The gpg_sign member of the replay_opts structure is of type `char *`,
meaning that the sequencer deems the string to which gpg_sign points to
be under its custody, i.e. it needs to be free()d by the sequencer.
Therefore, let's only assign malloc()ed buffers to it.
Reported-by: Kaartic Sivaraam
S
5 matches
Mail list logo
