Re: [PATCH] send-pack.c: mark a file-local function static

2013-12-13 Thread Ramsay Jones
On 13/12/13 00:58, Duy Nguyen wrote: > On Fri, Dec 13, 2013 at 6:15 AM, Ramsay Jones > wrote: >> BTW, I have not been following these patches, but I noticed that the >> 'remove_nonexistent_ours_in_pack()' function has no callers. (There are >> two commented out callers - but they seem to have *alw

Re: [PATCH] send-pack.c: mark a file-local function static

2013-12-12 Thread Duy Nguyen
On Fri, Dec 13, 2013 at 6:15 AM, Ramsay Jones wrote: > BTW, I have not been following these patches, but I noticed that the > 'remove_nonexistent_ours_in_pack()' function has no callers. (There are > two commented out callers - but they seem to have *always* been commented > out ;-) ). So, step 5

[PATCH] send-pack.c: mark a file-local function static

2013-12-12 Thread Ramsay Jones
Commit f2c681cf ("send-pack: support pushing from a shallow clone via http", 05-12-2013) adds the 'advertise_shallow_grafts_buf' function as an external symbol. This symbol does not require more than file visibility. Noticed by sparse. ("'advertise_shallow_grafts_buf' was not declared. Should it