Re: [PATCH] send-pack: use internal argv_array of struct child_process

2017-12-22 Thread Junio C Hamano
Stefan Beller writes: >> + argv_array_push(&po.args, "pack-objects"); >> + argv_array_push(&po.args, "--all-progress-implied"); >> + argv_array_push(&po.args, "--revs"); >> + argv_array_push(&po.args, "--stdout"); > > (useless nit of the day, no need to resend:) > These fo

Re: [PATCH] send-pack: use internal argv_array of struct child_process

2017-12-22 Thread Stefan Beller
On Fri, Dec 22, 2017 at 12:14 AM, René Scharfe wrote: > Avoid a magic number of NULL placeholder values and a magic index by > constructing the command line for pack-objects using the embedded > argv_array of the child_process. The resulting code is shorter and > easier to extend. > > Signed-off-

[PATCH] send-pack: use internal argv_array of struct child_process

2017-12-22 Thread René Scharfe
Avoid a magic number of NULL placeholder values and a magic index by constructing the command line for pack-objects using the embedded argv_array of the child_process. The resulting code is shorter and easier to extend. Signed-off-by: Rene Scharfe --- send-pack.c | 28 +-