Re: [PATCH] run-command: do not pass child process data into callbacks

2016-03-01 Thread Junio C Hamano
Johannes Sixt writes: > Am 29.02.2016 um 22:57 schrieb Stefan Beller: >> The expected way to pass data into the callback is to pass them via >> the customizable callback pointer. The error reporting in >> default_{start_failure, task_finished} is not user friendly enough, that >> we want to encou

Re: [PATCH] run-command: do not pass child process data into callbacks

2016-02-29 Thread Johannes Sixt
Am 29.02.2016 um 22:57 schrieb Stefan Beller: > The expected way to pass data into the callback is to pass them via > the customizable callback pointer. The error reporting in > default_{start_failure, task_finished} is not user friendly enough, that > we want to encourage using the child data for

Re: [PATCH] run-command: do not pass child process data into callbacks

2016-02-29 Thread Junio C Hamano
Stefan Beller writes: > It applies on 2.8.0-rc0. > > (I tried backporting it to 2.7, but realized it is not an issue there) Thanks. I tried to be nice to rebase the parallel-update stuff on top of this myself, but stopped it as I won't have enough time to push the result out for the day anyway.

Re: [PATCH] run-command: do not pass child process data into callbacks

2016-02-29 Thread Stefan Beller
It applies on 2.8.0-rc0. (I tried backporting it to 2.7, but realized it is not an issue there) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] run-command: do not pass child process data into callbacks

2016-02-29 Thread Stefan Beller
The expected way to pass data into the callback is to pass them via the customizable callback pointer. The error reporting in default_{start_failure, task_finished} is not user friendly enough, that we want to encourage using the child data for such purposes. Furthermore the struct child data is c