Re: [PATCH] rm: do not set a variable twice without intermediate reading.

2013-07-23 Thread Junio C Hamano
Stefan Beller writes: > On 07/23/2013 08:32 PM, Junio C Hamano wrote: >> Interesting. This is ancient and dates back to 7612a1ef (git-rm: >> honor -n flag., 2006-06-08). > Originally it comes from d9b814cc97 (by Linus), which introduced: > + seen = NULL; > + if (pathspec) { > +

Re: [PATCH] rm: do not set a variable twice without intermediate reading.

2013-07-23 Thread Stefan Beller
On 07/23/2013 08:32 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Just the next line assigns a non-null value to seen. >> >> Signed-off-by: Stefan Beller >> --- >> builtin/rm.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/builtin/rm.c b/builtin/rm.c >> index 5b63d3f..df85

Re: [PATCH] rm: do not set a variable twice without intermediate reading.

2013-07-23 Thread Junio C Hamano
Stefan Beller writes: > Just the next line assigns a non-null value to seen. > > Signed-off-by: Stefan Beller > --- > builtin/rm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/builtin/rm.c b/builtin/rm.c > index 5b63d3f..df85f98 100644 > --- a/builtin/rm.c > +++ b/builtin/rm.c > @@ -

[PATCH] rm: do not set a variable twice without intermediate reading.

2013-07-23 Thread Stefan Beller
Just the next line assigns a non-null value to seen. Signed-off-by: Stefan Beller --- builtin/rm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/builtin/rm.c b/builtin/rm.c index 5b63d3f..df85f98 100644 --- a/builtin/rm.c +++ b/builtin/rm.c @@ -316,7 +316,6 @@ int cmd_rm(int argc, const cha