Re: [PATCH] revisions --stdin: accept CRLF line terminators

2015-08-12 Thread Johannes Sixt
Am 12.08.2015 um 00:14 schrieb Junio C Hamano: Now, I am wondering if it makes sense to do these two things: * Teach revision.c::read_revisions_from_stdin() to use strbuf_getline() instead of strbuf_getwholeline(). * Teach strbuf_getline() to remove CR at the end when stripping the

Re: [PATCH] revisions --stdin: accept CRLF line terminators

2015-08-11 Thread Junio C Hamano
Junio C Hamano writes: > Johannes Sixt writes: > >> On Windows, 'git rebase -i' with rebase.missingCommitsCheck set to >> warn or error reports: >> >>Dropped commits (newer to older): >>'atal: bad revision '410dee56... >> >> The error comes from the git rev-list --stdin invocation in >>

Re: [PATCH] revisions --stdin: accept CRLF line terminators

2015-08-11 Thread Junio C Hamano
Johannes Sixt writes: > On Windows, 'git rebase -i' with rebase.missingCommitsCheck set to > warn or error reports: > >Dropped commits (newer to older): >'atal: bad revision '410dee56... > > The error comes from the git rev-list --stdin invocation in > git-rebase--interactive.sh (function

[PATCH] revisions --stdin: accept CRLF line terminators

2015-08-11 Thread Johannes Sixt
On Windows, 'git rebase -i' with rebase.missingCommitsCheck set to warn or error reports: Dropped commits (newer to older): 'atal: bad revision '410dee56... The error comes from the git rev-list --stdin invocation in git-rebase--interactive.sh (function check_todo_list). It is caused by CRs