Re: [PATCH] revision.c: drop missing objects from cmdline

2018-10-25 Thread Matthew DeVore
On Tue, Oct 23, 2018 at 9:54 PM Junio C Hamano wrote: > > Matthew DeVore writes: > > > No code which reads cmdline in struct rev_info can handle NULL objects > > in cmdline.rev[i].item, so stop adding them to the cmdline.rev array. > > "The code is not prepared to have cmdline.rev[].item that is

Re: [PATCH] revision.c: drop missing objects from cmdline

2018-10-23 Thread Junio C Hamano
Matthew DeVore writes: > No code which reads cmdline in struct rev_info can handle NULL objects > in cmdline.rev[i].item, so stop adding them to the cmdline.rev array. "The code is not prepared to have cmdline.rev[].item that is NULL" is something everybody would understand and agree with, but t

[PATCH] revision.c: drop missing objects from cmdline

2018-10-23 Thread Matthew DeVore
No code which reads cmdline in struct rev_info can handle NULL objects in cmdline.rev[i].item, so stop adding them to the cmdline.rev array. Objects in cmdline are NULL when the given object is promisor and --exclude-promisor-objects is enabled. This new behavior avoids a segmentation fault in the