Re: [PATCH] revision.c: Remove unneeded check for NULL

Jeff King wrote: > On Fri, Jun 26, 2015 at 12:40:19PM -0700, Stefan Beller wrote: >>> This code seems to be underdocumented. >> >> I am not a expert in this area of the code, so I hoped Peff >> would document it if he feels like so. > > I kind of thought that the explanation in b6e8a3b covered thi

Re: [PATCH] revision.c: Remove unneeded check for NULL

On Fri, Jun 26, 2015 at 12:40:19PM -0700, Stefan Beller wrote: > The function is called only from one place, which makes sure > to have `interesting_cache` not NULL. Additionally it is a > dereferenced a few lines before unconditionally, which would > result in a segmentation fault. Yeah, I think

[PATCH] revision.c: Remove unneeded check for NULL

The function is called only from one place, which makes sure to have `interesting_cache` not NULL. Additionally it is a dereferenced a few lines before unconditionally, which would result in a segmentation fault. Signed-off-by: Stefan Beller --- Notes: > So I think the right solution is just