Re: [PATCH] revision: remove stray whitespace when name empty

2019-06-13 Thread Jeff King
On Wed, Jun 12, 2019 at 12:37:45PM -0700, Emily Shaffer wrote: > > > Alternatively, it would be reasonable to me to have an option for > > > "rev-list --objects" to have an option to suppress the filename (and > > > space) entirely. > > > > Yup, I think that is a more reasonable short-term change

Re: [PATCH] revision: remove stray whitespace when name empty

2019-06-12 Thread Emily Shaffer
On Mon, Jun 10, 2019 at 09:29:14AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Your patch only helps with this at all because you're using the "tree:1" > > ... > > because there you'll have actual names which cat-file will choke on. So > > it seems like this is helping only a very limi

Re: [PATCH] revision: remove stray whitespace when name empty

2019-06-12 Thread Emily Shaffer
On Fri, Jun 07, 2019 at 08:42:45PM -0400, Eric Sunshine wrote: > On Fri, Jun 7, 2019 at 6:59 PM Emily Shaffer wrote: > > Teach show_object_with_name() to avoid writing a space before a name > > which is empty. Also teach tests for rev-list --objects --filter to not > > require a space between the

Re: [PATCH] revision: remove stray whitespace when name empty

2019-06-10 Thread Junio C Hamano
Jeff King writes: > Your patch only helps with this at all because you're using the "tree:1" > ... > because there you'll have actual names which cat-file will choke on. So > it seems like this is helping only a very limited use case. > ... > Alternatively, it would be reasonable to me to have an

Re: [PATCH] revision: remove stray whitespace when name empty

2019-06-09 Thread Jeff King
On Fri, Jun 07, 2019 at 03:59:00PM -0700, Emily Shaffer wrote: > Teach show_object_with_name() to avoid writing a space before a name > which is empty. Also teach tests for rev-list --objects --filter to not > require a space between the object ID and name. > [...] > --- > I don't see any reason _

Re: [PATCH] revision: remove stray whitespace when name empty

2019-06-07 Thread Eric Sunshine
On Fri, Jun 7, 2019 at 6:59 PM Emily Shaffer wrote: > Teach show_object_with_name() to avoid writing a space before a name > which is empty. Also teach tests for rev-list --objects --filter to not > require a space between the object ID and name. > [...] > Signed-off-by: Emily Shaffer > --- > Not

[PATCH] revision: remove stray whitespace when name empty

2019-06-07 Thread Emily Shaffer
Teach show_object_with_name() to avoid writing a space before a name which is empty. Also teach tests for rev-list --objects --filter to not require a space between the object ID and name. show_object_with_name() inserts a space between an object's OID and name regardless of whether the name is em