Re: [PATCH] rev-parse: include HEAD in --all output

2014-09-03 Thread Max Kirillov
On Tue, Sep 02, 2014 at 09:59:17AM -0700, Junio C Hamano wrote: > > I would rather see "rev-parse --all" not to include HEAD, > especially if it has been documented that way. Ok, then probably I'll want to change it in gitk. But, with the "multiple working trees" feature, I would also want to ge

Re: [PATCH] rev-parse: include HEAD in --all output

2014-09-02 Thread Junio C Hamano
Max Kirillov writes: > btw, manpage for git-rev-parse says "Show all refs found in > refs/.", should it also be changed? I would rather see "rev-parse --all" not to include HEAD, especially if it has been documented that way. -- To unsubscribe from this list: send the line "unsubscribe git" in

Re: [PATCH] rev-parse: include HEAD in --all output

2014-08-31 Thread Max Kirillov
On Sun, Aug 31, 2014 at 11:30:54AM -0400, Jeff King wrote: > On Sun, Aug 31, 2014 at 01:24:48AM +0300, Max Kirillov wrote: > >> for_each_ref() does not include it itself, and without >> the hash the detached HEAD may be missed by some >> frontends (like gitk). >> >> Add test which verifies the he

Re: [PATCH] rev-parse: include HEAD in --all output

2014-08-31 Thread Jeff King
On Sun, Aug 31, 2014 at 01:24:48AM +0300, Max Kirillov wrote: > for_each_ref() does not include it itself, and without the hash > the detached HEAD may be missed by some frontends (like gitk). > > Add test which verifies the head is returned > > Update test t6018-rev-list-glob.sh which relied on

[PATCH] rev-parse: include HEAD in --all output

2014-08-30 Thread Max Kirillov
for_each_ref() does not include it itself, and without the hash the detached HEAD may be missed by some frontends (like gitk). Add test which verifies the head is returned Update test t6018-rev-list-glob.sh which relied on exact list of returned hashes. Signed-off-by: Max Kirillov --- builtin/