Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-14 Thread Michael J Gruber
hunderbird/15.0 [no, that Thunderbird user isn't Junio] > MIME-Version: 1.0 > To: Michael J Gruber > CC: git@vger.kernel.org > Subject: Re: [PATCH] rev-list/log: document logic with several limiting > options > Michael J Gruber venit, vidit, dixit 14.09.2012 09:46: > [sn

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-14 Thread Junio C Hamano
Michael J Gruber venit, vidit, dixit 14.09.2012 09:46: [snipped, just adding] ...and maybe the meaning of "(or ...)" and "*or*" isn't what I think it is either? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-14 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 13.09.2012 23:21: > Michael J Gruber writes: > >> Thanks for "this" ;) > > Here is a replacement to "this", that adds the "--debug" option to > "git grep" and an equivalent "--debug-grep" to "git log" family. > > -- >8 -- > Subject: [PATCH] grep: teach --debug

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-13 Thread Junio C Hamano
Michael J Gruber writes: > Thanks for "this" ;) Here is a replacement to "this", that adds the "--debug" option to "git grep" and an equivalent "--debug-grep" to "git log" family. -- >8 -- Subject: [PATCH] grep: teach --debug option to dump the parse tree Our "grep" allows complex boolean expr

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-13 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 12.09.2012 19:25: > Michael J Gruber writes: > >> It was introduced in 0ab7befa with a clear meaning (AND everything), >> then the general logic (without --all-match) was modified in 80235ba7 >> (to take headermatch AND (all greps ORed)), and 5aaeb733 finally ma

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-12 Thread Junio C Hamano
Junio C Hamano writes: > This is what I used to use when adding these generalized grep > boolean expressions. > > With this applied,... And this is the "this" X-<. grep.c | 90 +- 1 file changed, 89 insertions(+), 1 deletion(-) d

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-12 Thread Junio C Hamano
Michael J Gruber writes: > It was introduced in 0ab7befa with a clear meaning (AND everything), > then the general logic (without --all-match) was modified in 80235ba7 > (to take headermatch AND (all greps ORed)), and 5aaeb733 finally made > multiple authors resp. committers get ORed among each o

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-12 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 11.09.2012 18:22: > Michael J Gruber writes: > >> The current behavior is probably as useful as it is confusing. In any >> case it is going to stay. So, document it. >> >> Signed-off-by: Michael J Gruber >> --- >> I would have written a test but don't really kn

Re: [PATCH] rev-list/log: document logic with several limiting options

2012-09-11 Thread Junio C Hamano
Michael J Gruber writes: > The current behavior is probably as useful as it is confusing. In any > case it is going to stay. So, document it. > > Signed-off-by: Michael J Gruber > --- > I would have written a test but don't really know where to stick it in. > rev-list has many small tests where

[PATCH] rev-list/log: document logic with several limiting options

2012-09-11 Thread Michael J Gruber
The current behavior is probably as useful as it is confusing. In any case it is going to stay. So, document it. Signed-off-by: Michael J Gruber --- I would have written a test but don't really know where to stick it in. rev-list has many small tests where it doesn't fit. Documentation/rev-list