Re: [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-29 Thread Ramsay Jones
On 29/11/17 01:35, brian m. carlson wrote: > On Tue, Nov 28, 2017 at 03:01:19AM +, Ramsay Jones wrote: >> >> Commit 78a6766802 ("Integrate hash algorithm support with repo setup", >> 2017-11-12) added a 'const struct git_hash_algo *hash_algo' field to the >> repository structure, without modi

Re: [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-28 Thread brian m. carlson
On Tue, Nov 28, 2017 at 03:01:19AM +, Ramsay Jones wrote: > > Commit 78a6766802 ("Integrate hash algorithm support with repo setup", > 2017-11-12) added a 'const struct git_hash_algo *hash_algo' field to the > repository structure, without modifying the initializer of the 'the_repo' > variable

Re: [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-27 Thread Junio C Hamano
Ramsay Jones writes: > Hi Junio, > > I don't recall Brian doing a re-roll of the 'bc/hash-algo' branch[1], but > now that it has been merged into the 'next' branch, sparse is barking on > that branch too. This patch (slightly different to the last one) applies > on top of 'next'. Thanks. Will q

[PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-27 Thread Ramsay Jones
Commit 78a6766802 ("Integrate hash algorithm support with repo setup", 2017-11-12) added a 'const struct git_hash_algo *hash_algo' field to the repository structure, without modifying the initializer of the 'the_repo' variable. This does not actually introduce a bug, since the '0' initializer for