Re: [PATCH] replace --edit: respect core.editor

2016-04-20 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Tue, 19 Apr 2016, Junio C Hamano wrote: > >> "git blame -L475,6 builtin/replace.c" points at b892bb45 (replace: add >> --edit option, 2014-04-26) and the commit log message names two people >> who can review this change, so that is what I am doing he

Re: [PATCH] replace --edit: respect core.editor

2016-04-19 Thread Johannes Schindelin
Hi Christian & Peff, On Wed, 20 Apr 2016, Christian Couder wrote: > On Wed, Apr 20, 2016 at 5:53 AM, Jeff King wrote: > > On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote: > > > >> I can understand "we only know edit mode needs config, and we know it > >> will never affect other mo

Re: [PATCH] replace --edit: respect core.editor

2016-04-19 Thread Johannes Schindelin
Hi Junio, On Tue, 19 Apr 2016, Junio C Hamano wrote: > "git blame -L475,6 builtin/replace.c" points at b892bb45 (replace: add > --edit option, 2014-04-26) and the commit log message names two people > who can review this change, so that is what I am doing here. D'oh. Sorry. Dscho -- To unsubscri

Re: [PATCH] replace --edit: respect core.editor

2016-04-19 Thread Christian Couder
On Wed, Apr 20, 2016 at 5:53 AM, Jeff King wrote: > On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote: > >> I can understand "we only know edit mode needs config, and we know >> it will never affect other modes to have the new call here", and it >> would be good for an emergency patch

Re: [PATCH] replace --edit: respect core.editor

2016-04-19 Thread Jeff King
On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote: > Johannes Schindelin writes: > > > We simply need to read the config, is all. > > > > This fixes https://github.com/git-for-windows/git/issues/733 > > > > Signed-off-by: Johannes Schindelin > > --- > > builtin/replace.c | 1 + > >

Re: [PATCH] replace --edit: respect core.editor

2016-04-19 Thread Junio C Hamano
"git blame -L475,6 builtin/replace.c" points at b892bb45 (replace: add --edit option, 2014-04-26) and the commit log message names two people who can review this change, so that is what I am doing here. Johannes Schindelin writes: > We simply need to read the config, is all. > > This fixes https

[PATCH] replace --edit: respect core.editor

2016-04-19 Thread Johannes Schindelin
We simply need to read the config, is all. This fixes https://github.com/git-for-windows/git/issues/733 Signed-off-by: Johannes Schindelin --- builtin/replace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/builtin/replace.c b/builtin/replace.c index 748c6ca..02b13f6 100644 --- a/builtin/