Re: [PATCH] repack: disable bitmaps-by-default if .keep files exist

2019-06-29 Thread SZEDER Gábor
ound = 1; > > > + break; > > > + } > > > + } > > > + closedir(dir); > > > + return found; > > > +} > > > > I think this can be replaced with just checking p->pack_keep for each > > item in the packed_g

Re: [PATCH] repack: disable bitmaps-by-default if .keep files exist

2019-06-28 Thread Ævar Arnfjörð Bjarmason
eak; >> > + } >> > + } >> > + closedir(dir); >> > + return found; >> > +} >> >> I think this can be replaced with just checking p->pack_keep for each >> item in the packed_git list. > > Good point, I tend to forg

[PATCH] repack: disable bitmaps-by-default if .keep files exist

2019-06-28 Thread Eric Wong
ust checking p->pack_keep for each > item in the packed_git list. Good point, I tend to forget git C API internals as soon as I learn them :x > That's racy, but then so is your code here, since it's really the child > pack-objects which is going to deal with the .keep. I don&#