Re: [PATCH] remote-hg: store converted URL

2013-01-15 Thread Junio C Hamano
Max Horn writes: > So far, all I look at do not deal with this at all. Any attempts > to deal with it should be pretty easy to recognize: The > remote-$backend would have to store something into the git config, > or else, verify the opaque token and refuse to work with it under > certain conditio

Re: [PATCH] remote-hg: store converted URL

2013-01-15 Thread Max Horn
On 15.01.2013, at 17:51, Junio C Hamano wrote: > Junio C Hamano writes: > >> Max Horn writes: >> ... >>> See also the discussion (yeah, this time a real one ;-) leading to this: >>> https://github.com/felipec/git/issues/2 >>> ... > > If I understand correctly, the $backend::$opaqueToken is a

Re: [PATCH] remote-hg: store converted URL

2013-01-15 Thread Max Horn
On 15.01.2013, at 17:05, Junio C Hamano wrote: > Max Horn writes: > >> On 14.01.2013, at 19:14, Junio C Hamano wrote: >> >>> What is lacking from this description is why it even needs to work >>> from a different working directory > > In your rewrite below, this is still lacking, I think.

Re: [PATCH] remote-hg: store converted URL

2013-01-15 Thread Junio C Hamano
Junio C Hamano writes: > Max Horn writes: > ... >> See also the discussion (yeah, this time a real one ;-) leading to this: >> https://github.com/felipec/git/issues/2 >> ... If I understand correctly, the $backend::$opaqueToken is a contract between the remote-helper and the remote-$backend t

Re: [PATCH] remote-hg: store converted URL

2013-01-15 Thread Junio C Hamano
Max Horn writes: > On 14.01.2013, at 19:14, Junio C Hamano wrote: > >> What is lacking from this description is why it even needs to work >> from a different working directory In your rewrite below, this is still lacking, I think. > Fully agreed. How about this commit message: > > -- >8 --

Re: [PATCH] remote-hg: store converted URL

2013-01-15 Thread Max Horn
On 14.01.2013, at 19:14, Junio C Hamano wrote: > Max Horn writes: > >> From: Felipe Contreras >> >> Mercurial might convert the URL to something more appropriate, like an >> absolute path. > > "What it is converted *TO*" is fairly clear with ", like an ...", > but from the first reading it w

Re: [PATCH] remote-hg: store converted URL

2013-01-14 Thread Junio C Hamano
Max Horn writes: > From: Felipe Contreras > > Mercurial might convert the URL to something more appropriate, like an > absolute path. "What it is converted *TO*" is fairly clear with ", like an ...", but from the first reading it was unclear to me "what it is converted *FROM*" and "*WHEN* the c

[PATCH] remote-hg: store converted URL

2013-01-09 Thread Max Horn
From: Felipe Contreras Mercurial might convert the URL to something more appropriate, like an absolute path. Lets store that instead of the original URL, which won't work from a different working directory if it's relative. Suggested-by: Max Horn Signed-off-by: Felipe Contreras Signed-off-by: