Re: [PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Antoine Pelisse
On Tue, Aug 6, 2013 at 8:36 AM, Junio C Hamano wrote: > Antoine Pelisse writes: > Quoting that part I was asking about again: > >> +# check and upgrade old organization >> +hg_path = os.path.join(shared_path, '.hg') >> +if os.path.exists(shared_path) and not os.path.exists

Re: [PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Junio C Hamano
Antoine Pelisse writes: > On Mon, Aug 5, 2013 at 11:02 PM, Junio C Hamano wrote: >> Antoine Pelisse writes: >> Is the untold >> and obvious-to-those-who-are-familiar-with-this-codepath assumption >> that it is guaranteed that there is at most one "*/clone/.hg" under >> shared_path? > > No, ther

Re: [PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Antoine Pelisse
On Mon, Aug 5, 2013 at 11:02 PM, Junio C Hamano wrote: > Antoine Pelisse writes: > Is the untold > and obvious-to-those-who-are-familiar-with-this-codepath assumption > that it is guaranteed that there is at most one "*/clone/.hg" under > shared_path? No, there is no such assumption. That is why

Re: [PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Junio C Hamano
Antoine Pelisse writes: > From: Felipe Contreras > > 6796d49 (remote-hg: use a shared repository store) introduced a bug by > making the shared repository '.git/hg', which is already used before > that patch, so clones that happened before that patch, fail after that > patch, because there's no

Re: [PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Antoine Pelisse
On Mon, Aug 5, 2013 at 9:31 PM, Felipe Contreras wrote: > On Mon, Aug 5, 2013 at 2:22 PM, Antoine Pelisse wrote: >> From: Felipe Contreras >> >> 6796d49 (remote-hg: use a shared repository store) introduced a bug by >> making the shared repository '.git/hg', which is already used before >> that

Re: [PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 2:22 PM, Antoine Pelisse wrote: > From: Felipe Contreras > > 6796d49 (remote-hg: use a shared repository store) introduced a bug by > making the shared repository '.git/hg', which is already used before > that patch, so clones that happened before that patch, fail after tha

[PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Antoine Pelisse
From: Felipe Contreras 6796d49 (remote-hg: use a shared repository store) introduced a bug by making the shared repository '.git/hg', which is already used before that patch, so clones that happened before that patch, fail after that patch, because there's no shared Mercurial repo. It's trivial

[PATCH] remote-hg: add shared repo upgrade

2013-08-05 Thread Antoine Pelisse
From: Felipe Contreras 6796d49 (remote-hg: use a shared repository store) introduced a bug by making the shared repository '.git/hg', which is already used before that patch, so clones that happened before that patch, fail after that patch, because there's no shared Mercurial repo. It's trivial