Re: [PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 8:59 AM, Antoine Pelisse wrote: > Would you mind squashing your changes into a patch ? I actually would, and I'm not going to explain why because people get offended way too easily in this mailing list. Maybe later. -- Felipe Contreras -- To unsubscribe from this list:

Re: [PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 8:51 AM, Jörn Hees wrote: > On 4 Aug 2013, at 15:31, Felipe Contreras wrote: >> This is my solution: >> >> --- a/contrib/remote-helpers/git-remote-hg.py >> +++ b/contrib/remote-helpers/git-remote-hg.py >> @@ -391,11 +391,22 @@ def get_repo(url, alias): >> os.ma

Re: [PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Antoine Pelisse
> --- a/contrib/remote-helpers/git-remote-hg.py > +++ b/contrib/remote-helpers/git-remote-hg.py > @@ -391,11 +391,22 @@ def get_repo(url, alias): > os.makedirs(dirname) > else: > shared_path = os.path.join(gitdir, 'hg') > -if not os.path.exists(shared_path): > -

Re: [PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Jörn Hees
On 4 Aug 2013, at 15:31, Felipe Contreras wrote: > git config --get-regexp '^remote.*.url' is probably more appropriate. > > Either way, I don't see why such a change should be in the same patch. +1 > This is my solution: > > --- a/contrib/remote-helpers/git-remote-hg.py > +++ b/contrib/remot

Re: [PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 7:17 AM, Jörn Hees wrote: > Hi, > > On 4 Aug 2013, at 12:38, Antoine Pelisse wrote: >> […] >> I also decided to always clone local repositories because what Jörn Hees >> said makes sense: >> If you have a local clone of a big repository, and then want to add a slow >> remot

Re: [PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 5:38 AM, Antoine Pelisse wrote: > 6796d49 (remote-hg: use a shared repository store) introduced sharing > repository capability, but it broke backward-compatibility with already > existing repositories. > > Indeed, 6796d49 assumes that .git/hg/.hg (the shared repository) wil

Re: [PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Jörn Hees
Hi, On 4 Aug 2013, at 12:38, Antoine Pelisse wrote: > […] > I also decided to always clone local repositories because what Jörn Hees > said makes sense: > If you have a local clone of a big repository, and then want to add a slow > remote, you would have to reclone everything. > I think the trade

[PATCH] remote-hg: Fix cloning and sharing bug

2013-08-04 Thread Antoine Pelisse
6796d49 (remote-hg: use a shared repository store) introduced sharing repository capability, but it broke backward-compatibility with already existing repositories. Indeed, 6796d49 assumes that .git/hg/.hg (the shared repository) will exist if .git/hg exists. This can be false for already existing