Re: [PATCH] remote-helpers: remove --graph in hg_log()

2013-04-06 Thread Felipe Contreras
On Sat, Apr 6, 2013 at 10:12 AM, Antoine Pelisse wrote: > On Sat, Apr 6, 2013 at 6:06 PM, Felipe Contreras > wrote: >> On Sat, Apr 6, 2013 at 10:00 AM, Antoine Pelisse wrote: >>> I'm not so confident that --graph is useless to the test. If it's really >>> necessary, it would be nice either to ac

Re: [PATCH] remote-helpers: remove --graph in hg_log()

2013-04-06 Thread Antoine Pelisse
On Sat, Apr 6, 2013 at 6:06 PM, Felipe Contreras wrote: > On Sat, Apr 6, 2013 at 10:00 AM, Antoine Pelisse wrote: >> I'm not so confident that --graph is useless to the test. If it's really >> necessary, it would be nice either to activate it in setup() or to use >> it just for the command throug

Re: [PATCH] remote-helpers: remove --graph in hg_log()

2013-04-06 Thread Felipe Contreras
On Sat, Apr 6, 2013 at 10:00 AM, Antoine Pelisse wrote: > The hg_log() test helper uses the "--graph" parameter that is > implemented by the GraphLog extension. If the extension is not activated > by the user, the parameter is not available. Do not use the option that > is unnecessary. > I'm not

[PATCH] remote-helpers: remove --graph in hg_log()

2013-04-06 Thread Antoine Pelisse
The hg_log() test helper uses the "--graph" parameter that is implemented by the GraphLog extension. If the extension is not activated by the user, the parameter is not available. Do not use the option that is unnecessary. Also changes the way we grep the output in hg_log(). The pipe operator can