Re: [PATCH] remote: handle pushremote config in any order order

2014-02-24 Thread Ramkumar Ramachandra
Jeff King wrote: > Thus, config like: > > [branch "master"] > pushremote = foo > [remote] > pushdefault = bar > > erroneously ends up pushing to "bar" from the master branch. Oh, ouch. Thanks for fixing this. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of

Re: [PATCH] remote: handle pushremote config in any order order

2014-02-24 Thread Junio C Hamano
Jeff King writes: > On Mon, Feb 24, 2014 at 12:32:32PM -0800, Junio C Hamano wrote: > >> >> +test_expect_success 'branch.*.pushremote config order is irrelevant' ' >> >> + mk_test one_repo heads/master && >> >> + mk_test two_repo heads/master && >> >> + test_config remote.one.url one_repo && >> >

Re: [PATCH] remote: handle pushremote config in any order order

2014-02-24 Thread Jeff King
On Mon, Feb 24, 2014 at 12:32:32PM -0800, Junio C Hamano wrote: > >> +test_expect_success 'branch.*.pushremote config order is irrelevant' ' > >> + mk_test one_repo heads/master && > >> + mk_test two_repo heads/master && > >> + test_config remote.one.url one_repo && > >> + test_config remote.t

Re: [PATCH] remote: handle pushremote config in any order order

2014-02-24 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> Yes, with a few exceptions, we usually try to make the ordering in the >> config file irrelevant. This is a bug. The patch below should fix it. > > Looks good. Thanks. >> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh >> index 926e7f6

Re: [PATCH] remote: handle pushremote config in any order order

2014-02-24 Thread Junio C Hamano
Jeff King writes: > Yes, with a few exceptions, we usually try to make the ordering in the > config file irrelevant. This is a bug. The patch below should fix it. Looks good. Thanks. > -- >8 -- > Subject: remote: handle pushremote config in any order > > The remote we push can be defined eithe

[PATCH] remote: handle pushremote config in any order order

2014-02-24 Thread Jeff King
On Mon, Feb 24, 2014 at 12:10:04AM -0500, Jack Nagel wrote: > There seems to be a difference in the behavior of "git push" depending > on whether remote.pushdefault is defined before or after > branch..pushremote in .git/config. > [...] > I would expect the order that things are defined in the con