Re: [PATCH] remote: check config validity before creating rewrite struct

2019-01-11 Thread Junio C Hamano
Jeff King writes: > This was a minor cleanup I mentioned in: > > https://public-inbox.org/git/20181122173109.gi28...@sigill.intra.peff.net/ > > but didn't get picked up. Yeah, that does sound vaguely familiar ;-) Thanks, will queue. > > remote.c | 4 ++-- > 1 file changed, 2 insertions(+),

[PATCH] remote: check config validity before creating rewrite struct

2019-01-11 Thread Jeff King
When parsing url.foo.insteadOf, we call make_rewrite() and only then check to make sure the value is a string (and return an error if it isn't). This isn't quite a leak, because the struct we allocate is part of a global array, but it does leave a funny half-finished struct. In practice, it doesn'