[PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-06-03 Thread Ronnie Sahlberg
read_ref_at has its own parsing of the reflog file for no really good reason so lets change this to use the existing reflog iterators. This removes one instance where we manually unmarshall the reflog file format. Remove the now redundant ref_msg function. Log messages for errors are changed slig

Re: [PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-06-03 Thread Ronnie Sahlberg
Thanks. On Mon, Jun 2, 2014 at 2:21 PM, Junio C Hamano wrote: > Ronnie Sahlberg writes: > >> read_ref_at has its own parsing of the reflog file for no really good reason >> so lets change this to use the existing reflog iterators. This removes one >> instance where we manually unmarshall the ref

Re: [PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-06-02 Thread Junio C Hamano
Ronnie Sahlberg writes: > read_ref_at has its own parsing of the reflog file for no really good reason > so lets change this to use the existing reflog iterators. This removes one > instance where we manually unmarshall the reflog file format. > > Log messages for errors are changed slightly. We

[PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-06-02 Thread Ronnie Sahlberg
read_ref_at has its own parsing of the reflog file for no really good reason so lets change this to use the existing reflog iterators. This removes one instance where we manually unmarshall the reflog file format. Log messages for errors are changed slightly. We no longer print the file name for t

Re: [PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-06-02 Thread Ronnie Sahlberg
On Fri, May 30, 2014 at 2:59 PM, Junio C Hamano wrote: > Ronnie Sahlberg writes: > >> read_ref_at has its own parsing of the reflog file for no really good reason >> so lets change this to use the existing reflog iterators. This removes one >> instance where we manually unmarshall the reflog file

Re: [PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-06-02 Thread Ronnie Sahlberg
Fixed. Thanks. On Fri, May 30, 2014 at 3:51 PM, Eric Sunshine wrote: > On Fri, May 30, 2014 at 3:51 PM, Ronnie Sahlberg wrote: >> read_ref_at has its own parsing of the reflog file for no really good reason >> so lets change this to use the existing reflog iterators. This removes one >> instance

Re: [PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-05-30 Thread Eric Sunshine
On Fri, May 30, 2014 at 3:51 PM, Ronnie Sahlberg wrote: > read_ref_at has its own parsing of the reflog file for no really good reason > so lets change this to use the existing reflog iterators. This removes one > instance where we manually unmarshall the reflog file format. > > Log messages for e

Re: [PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-05-30 Thread Junio C Hamano
Ronnie Sahlberg writes: > read_ref_at has its own parsing of the reflog file for no really good reason > so lets change this to use the existing reflog iterators. This removes one > instance where we manually unmarshall the reflog file format. > > Log messages for errors are changed slightly. We

[PATCH] refs.c: change read_ref_at to use the reflog iterators

2014-05-30 Thread Ronnie Sahlberg
read_ref_at has its own parsing of the reflog file for no really good reason so lets change this to use the existing reflog iterators. This removes one instance where we manually unmarshall the reflog file format. Log messages for errors are changed slightly. We no longer print the file name for t