Re: [PATCH] ref-filter: initialize empty name or email fields

2019-08-22 Thread Mischa POSLAWSKY
Junio wrote: > Junio C Hamano writes: > > > Mischa POSLAWSKY writes: > > > >> Formatting $(taggername) on headerless tags such as v0.99 in Git > >> causes a SIGABRT with error "munmap_chunk(): invalid pointer", > >> because of an oversight in commit f0062d3b74 (ref-filter: free > >> item->value

Re: [PATCH] ref-filter: initialize empty name or email fields

2019-08-21 Thread Junio C Hamano
Junio C Hamano writes: > Mischa POSLAWSKY writes: > >> If I understand correctly, such tags cannot be produced normally anymore. >> Therefore I'm unsure how to make tests, and if that is even warranted. > > Thanks for spotting. A quick trial to recreate a tag object seems to succeed: $ git

Re: [PATCH] ref-filter: initialize empty name or email fields

2019-08-20 Thread Junio C Hamano
Junio C Hamano writes: > Mischa POSLAWSKY writes: > >> Formatting $(taggername) on headerless tags such as v0.99 in Git >> causes a SIGABRT with error "munmap_chunk(): invalid pointer", >> because of an oversight in commit f0062d3b74 (ref-filter: free >> item->value and item->value->s, 2018-10-1

Re: [PATCH] ref-filter: initialize empty name or email fields

2019-08-19 Thread Junio C Hamano
Mischa POSLAWSKY writes: > Formatting $(taggername) on headerless tags such as v0.99 in Git > causes a SIGABRT with error "munmap_chunk(): invalid pointer", > because of an oversight in commit f0062d3b74 (ref-filter: free > item->value and item->value->s, 2018-10-19). > > Signed-off-by: Mischa PO

[PATCH] ref-filter: initialize empty name or email fields

2019-08-17 Thread Mischa POSLAWSKY
Formatting $(taggername) on headerless tags such as v0.99 in Git causes a SIGABRT with error "munmap_chunk(): invalid pointer", because of an oversight in commit f0062d3b74 (ref-filter: free item->value and item->value->s, 2018-10-19). Signed-off-by: Mischa POSLAWSKY --- If I understand correctly