Re: [PATCH] receive-pack: Create a HEAD ref for ref namespace

2015-06-05 Thread Johannes Löthberg
On 05/06, Michael J Gruber wrote: (Also, your patch duplicates the line "struct strbuf namespaced_head_buf = STRBUF_INIT;") I replied too soon, it doesn't duplicate it, it's a different variable named similarly. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos

Re: [PATCH] receive-pack: Create a HEAD ref for ref namespace

2015-06-05 Thread Johannes Löthberg
On 05/06, Michael J Gruber wrote: It appears your patch proposes to fix a problem. It's a good idea to expose the problem by writing a test so that one can check that the fix actually fixes the problem. Right, will look into writing a test for it. (Also, your patch duplicates the line "struct

Re: [PATCH] receive-pack: Create a HEAD ref for ref namespace

2015-06-05 Thread Michael J Gruber
Johannes Löthberg venit, vidit, dixit 05.06.2015 13:53: > Ping. > > -- > Sincerely, > Johannes Löthberg > (Sent from my phone.) > It appears your patch proposes to fix a problem. It's a good idea to expose the problem by writing a test so that one can check that the fix actually fixes the prob

Re: [PATCH] receive-pack: Create a HEAD ref for ref namespace

2015-06-05 Thread Johannes Löthberg
Ping. -- Sincerely, Johannes Löthberg (Sent from my phone.)N�r��yb�X��ǧv�^�)޺{.n�+ا���ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf

[PATCH] receive-pack: Create a HEAD ref for ref namespace

2015-06-01 Thread Johannes Löthberg
Each ref namespace have their own separate branches, tags, and HEAD, so when pushing to a namespace we need to make sure that there exists a HEAD ref for the namespace, otherwise you will not be able to check out the repo after cloning from a namespace --- So, I have absolutely no clue where this