Re: [PATCH] rebase--interactive: count squash commits above 10 correctly

2017-01-07 Thread Junio C Hamano
Jeff King writes: > git-rebase--interactive.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh > index b0a6f2b7ba..4734094a3f 100644 > --- a/git-rebase--interactive.sh > +++ b/git-rebase--interactive.sh > @@ -425,7

Re: [PATCH] rebase--interactive: count squash commits above 10 correctly

2017-01-07 Thread Jeff King
On Sat, Jan 07, 2017 at 11:51:23AM +0100, Johannes Schindelin wrote: > > We can fix this by making the ".*" less greedy. Instead of > > depending on ".*?" working portably, we can just limit the > > match to non-digit characters, which accomplishes the same > > thing. > > Or we could simply requi

Re: [PATCH] rebase--interactive: count squash commits above 10 correctly

2017-01-07 Thread Johannes Schindelin
Hi Peff, On Sat, 7 Jan 2017, Jeff King wrote: > On Fri, Jan 06, 2017 at 01:04:05AM -0800, Brandon Tolsch wrote: > > We can fix this by making the ".*" less greedy. Instead of > depending on ".*?" working portably, we can just limit the > match to non-digit characters, which accomplishes the same

[PATCH] rebase--interactive: count squash commits above 10 correctly

2017-01-07 Thread Jeff King
On Fri, Jan 06, 2017 at 01:04:05AM -0800, Brandon Tolsch wrote: > git --version: 2.11.0 > > When using git rebase -i to squash a series of commits that includes > more than 10 commits, the generated commit message you are given to > edit counts the old messages incorrectly. It will say the total