Re: [PATCH] rebase: fix regression in rebase.useBuiltin=false test mode

2019-02-14 Thread Phillip Wood
Hi Ævar On 13/02/2019 21:49, Ævar Arnfjörð Bjarmason wrote: Fix a recently introduced regression in c762aada1a ("rebase -x: sanity check command", 2019-01-29) triggered when running the tests with GIT_TEST_REBASE_USE_BUILTIN=false. See 62c23938fa ("tests: add a special setup where rebase.useBuil

Re: [PATCH] rebase: fix regression in rebase.useBuiltin=false test mode

2019-02-13 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Let's do this for 2.21 then and I'll re-submit the legacy removal > patch after we start 2.22. OK, I would have thought that a prereq to check if the environment is set and skip these problematic tests would be a lot cleaner (primarily because the "legacy remov

[PATCH] rebase: fix regression in rebase.useBuiltin=false test mode

2019-02-13 Thread Ævar Arnfjörð Bjarmason
Fix a recently introduced regression in c762aada1a ("rebase -x: sanity check command", 2019-01-29) triggered when running the tests with GIT_TEST_REBASE_USE_BUILTIN=false. See 62c23938fa ("tests: add a special setup where rebase.useBuiltin is off", 2018-11-14) for how that test mode works. As disc