Re: [PATCH] push: allow atomic flag via configuration

2017-03-27 Thread Jonathan Nieder
Hi, Romuald Brunet wrote: > On ven., 2017-03-24 at 12:29 -0700, Junio C Hamano wrote: >> Jeff King writes: >>> My one question would be whether people would want this to actually be >>> specific to a particular remote, and not just on for a given repository >>> (your "site-specific" in the descr

Re: [PATCH] push: allow atomic flag via configuration

2017-03-27 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Fri, Mar 24, 2017 at 6:17 PM, Romuald Brunet wrote: >> +test_expect_success 'atomic option possible via git-config' ' >> + # prepare the repo >> + mk_repo_pair && >> + ( >> + cd workbench && >> + test_commit one &

Re: [PATCH] push: allow atomic flag via configuration

2017-03-27 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 24, 2017 at 6:17 PM, Romuald Brunet wrote: > +test_expect_success 'atomic option possible via git-config' ' > + # prepare the repo > + mk_repo_pair && > + ( > + cd workbench && > + test_commit one && > + git checkout -b second

Re: [PATCH] push: allow atomic flag via configuration

2017-03-27 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 24, 2017 at 6:17 PM, Romuald Brunet wrote: > +push.atomic:: > + If set to true enable `--atomic` option by default. You > + may override this configuration at time of push by specifying > + `--no-atomic`. > + This should also be mentioned in the --atomic documentati

Re: [PATCH] push: allow atomic flag via configuration

2017-03-27 Thread Romuald Brunet
On ven., 2017-03-24 at 12:29 -0700, Junio C Hamano wrote: > Jeff King writes: > > > My one question would be whether people would want this to actually be > > specific to a particular remote, and not just on for a given repository > > (your "site-specific" in the description made me think of that

Re: [PATCH] push: allow atomic flag via configuration

2017-03-24 Thread Junio C Hamano
Jeff King writes: > My one question would be whether people would want this to actually be > specific to a particular remote, and not just on for a given repository > (your "site-specific" in the description made me think of that). In that > case it would be better as part of the remote.* config.

Re: [PATCH] push: allow atomic flag via configuration

2017-03-24 Thread Jeff King
On Fri, Mar 24, 2017 at 11:53:54AM -0700, Jonathan Nieder wrote: > I didn't receive the original patch (maybe mailing delay?) so > commenting here. Vger seems a bit slow lately. The list copy did eventually get delivered to me and public-inbox: http://public-inbox.org/git/1490375874.745.227.ca

Re: [PATCH] push: allow atomic flag via configuration

2017-03-24 Thread Jonathan Nieder
Hi, Jeff King wrote: > On Fri, Mar 24, 2017 at 06:17:54PM +0100, Romuald Brunet wrote: >> Added a "push.atomic" option to git-config to allow site-specific >> configuration of the atomic flag of git push > > I don't really use --atomic myself, but this seems like a reasonable > thing to want, and

Re: [PATCH] push: allow atomic flag via configuration

2017-03-24 Thread Jeff King
On Fri, Mar 24, 2017 at 06:17:54PM +0100, Romuald Brunet wrote: > Added a "push.atomic" option to git-config to allow site-specific > configuration of the atomic flag of git push I don't really use --atomic myself, but this seems like a reasonable thing to want, and the implementation looks clean

[PATCH] push: allow atomic flag via configuration

2017-03-24 Thread Romuald Brunet
Added a "push.atomic" option to git-config to allow site-specific configuration of the atomic flag of git push Signed-off-by: Romuald Brunet --- Documentation/config.txt | 5 + builtin/push.c | 6 ++ contrib/completion/git-completion.bash | 1 + t