Re: [PATCH] push: add recurseSubmodules config option

2015-11-30 Thread Mike Crowe
On Monday 30 November 2015 at 10:31:26 -0800, Junio C Hamano wrote: > Mike Crowe writes: > > > diff --git a/builtin/push.c b/builtin/push.c > > index 3bda430..dfced74 100644 > > --- a/builtin/push.c > > +++ b/builtin/push.c > > @@ -9,6 +9,7 @@ > > #include "transport.h" > > #include "parse-opti

Re: [PATCH] push: add recurseSubmodules config option

2015-11-30 Thread Junio C Hamano
Mike Crowe writes: > diff --git a/builtin/push.c b/builtin/push.c > index 3bda430..dfced74 100644 > --- a/builtin/push.c > +++ b/builtin/push.c > @@ -9,6 +9,7 @@ > #include "transport.h" > #include "parse-options.h" > #include "submodule.h" > +#include "submodule-config.h" > #include "send-pa

Re: [PATCH] push: add recurseSubmodules config option

2015-11-16 Thread Eric Sunshine
On Mon, Nov 16, 2015 at 8:24 AM, Mike Crowe wrote: > The --recurse-submodules command line parameter has existed for some > time but it has no config file equivalent. > > Following the style of the corresponding parameter for git fetch, let's > invent push.recurseSubmodules to provide a default fo

Re: [PATCH] push: add recurseSubmodules config option

2015-11-16 Thread Jens Lehmann
Am 16.11.2015 um 19:31 schrieb Mike Crowe: On Monday 16 November 2015 at 10:15:24 -0800, Stefan Beller wrote: The code itself looks good to me, one nit in the tests though. @@ -79,6 +87,119 @@ test_expect_success 'push succeeds after commit was pushed to remote' ' ) ' +test_expect

Re: [PATCH] push: add recurseSubmodules config option

2015-11-16 Thread Mike Crowe
On Monday 16 November 2015 at 10:15:24 -0800, Stefan Beller wrote: > The code itself looks good to me, one nit in the tests though. > > > @@ -79,6 +87,119 @@ test_expect_success 'push succeeds after commit was > > pushed to remote' ' > > ) > > ' > > > > +test_expect_success 'push succeed

Re: [PATCH] push: add recurseSubmodules config option

2015-11-16 Thread Stefan Beller
On Mon, Nov 16, 2015 at 5:24 AM, Mike Crowe wrote: > The --recurse-submodules command line parameter has existed for some > time but it has no config file equivalent. > > Following the style of the corresponding parameter for git fetch, let's > invent push.recurseSubmodules to provide a default fo

[PATCH] push: add recurseSubmodules config option

2015-11-16 Thread Mike Crowe
The --recurse-submodules command line parameter has existed for some time but it has no config file equivalent. Following the style of the corresponding parameter for git fetch, let's invent push.recurseSubmodules to provide a default for this parameter. This also requires the addition of --recurs