Re: [PATCH] pull: warn on --verify-signatures with --rebase

2016-05-19 Thread Junio C Hamano
Alexander 'z33ky' Hirsch <1ze...@gmail.com> writes: > Would "ignoring --verify-signatures for rebase" be sufficient? It does > not describe why it is ignored though. Yeah, I agree that that would be sufficient. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mes

Re: [PATCH] pull: warn on --verify-signatures with --rebase

2016-05-19 Thread Alexander 'z33ky' Hirsch
On Wed, May 18, 2016 at 09:04:24AM -0700, Junio C Hamano wrote: > > Previously git-pull silently ignored the --verify-signatures option for > > --rebase. > > Missing pieces information that would have made the patch more > complete are answers to these questions: > > - Is that a bad thing? Why?

Re: [PATCH] pull: warn on --verify-signatures with --rebase

2016-05-18 Thread Junio C Hamano
Alexander 'z33ky' Hirsch <1ze...@gmail.com> writes: > Previously git-pull silently ignored the --verify-signatures option for > --rebase. Missing pieces information that would have made the patch more complete are answers to these questions: - Is that a bad thing? Why? - Assuming it is a bad

[PATCH] pull: warn on --verify-signatures with --rebase

2016-05-18 Thread Alexander 'z33ky' Hirsch
Previously git-pull silently ignored the --verify-signatures option for --rebase. Signed-off-by: Alexander 'z33ky' Hirsch <1ze...@gmail.com> --- Sorry it took so long for the update. I made git-pull warn instead or error and explained why "the --verify-signatures option does not work for --rebase